Add TraceDataCollectorDirectoryPath parameter to VSTestTask#1601
Merged
smadala merged 5 commits intomicrosoft:masterfrom May 16, 2018
Merged
Add TraceDataCollectorDirectoryPath parameter to VSTestTask#1601smadala merged 5 commits intomicrosoft:masterfrom
smadala merged 5 commits intomicrosoft:masterfrom
Conversation
| } | ||
|
|
||
| [TestMethod] | ||
| public void CreateArgumentShouldAddTraceCollectorDirectoryPathAsTestAdapterIfSettingsGiven() |
Contributor
There was a problem hiding this comment.
Nit: Check if we can add another test where VSTestTraceDataCollectorDirectoryPath is empty, so it is not set if if runsettings is present
|
|
||
| if (isCollectCodeCoverageEnabled || isRunSettingsEnabled) | ||
| { | ||
| // Pass TraceDataCollector path to vstest.console as TestAdapterPath if --collect "Code Coverage" |
Contributor
There was a problem hiding this comment.
Here trade off is b/w always parsing runsettings(which we don't want to do), vs always adding the path of TraceDataCollector dir if it is present, & runsettings is used.
I agree with latter. #ByDesign
…m/smadala/vstest into add-trace-datacollector-parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Value for TraceDataCollectorDirectoryPath will be passed from targets present in Microsoft.CodeCoverage package. More details
Related issue
#981